RESTWS-737: Remove redundant usages of @PropertySetter for metadata f… #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ODORA0 In the jira it says should be only implemented once https://issues.openmrs.org/browse/RESTWS-739 is done. i can see its still in progress and there are no PRs attached to it |
|
Yes @dilanthas Once the assignee is able to have a merged PR for RESTWS-739, then I will be able to update this PR as well |
|
@ODORA0 did you have this pass locally? |
|
@HerbertYiga Same error here is the same error locally |
|
Did you try figure it out by looking at the error log? If you still cannot, can you ask for help on talk? |
|
I think I have been able to fix some of these potential errors @dkayiwa @HerbertYiga |
ibacher
force-pushed
the
master
branch
2 times, most recently
from
f9c73bb
to
2a4407f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ields
Issue worked on: https://issues.openmrs.org/browse/RESTWS-737
Removed some of the redundant usages of @PropertySetter