Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use http framework for features #900

Merged
merged 10 commits into from
May 17, 2024
Merged

Conversation

turip
Copy link
Contributor

@turip turip commented May 14, 2024

Overview

Rewrite existing implementation to work better with our http_framework, allowing better reuse of the handlers.

Notes for reviewer

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@turip turip force-pushed the refactor/use-http-framework branch from 9573308 to 49531ba Compare May 15, 2024 06:57
@turip turip changed the base branch from main to feature/upsert-ledger-2 May 15, 2024 06:57
Base automatically changed from feature/upsert-ledger-2 to main May 15, 2024 10:11
@turip turip force-pushed the refactor/use-http-framework branch from 49531ba to 9b35381 Compare May 15, 2024 13:11
@turip turip added area/api kind/refactor Code refactor, cleanup or minor improvement labels May 16, 2024
@turip turip requested a review from chrisgacsal May 16, 2024 14:55
@turip turip marked this pull request as ready for review May 17, 2024 08:45
@turip turip requested a review from sagikazarmark May 17, 2024 08:45
@turip turip merged commit 6cf5bd9 into main May 17, 2024
20 of 21 checks passed
@turip turip deleted the refactor/use-http-framework branch May 17, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/refactor Code refactor, cleanup or minor improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants