test: add failing test for empty group by #634
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Sagi-Kazar <[email protected]>
sagikazarmark
force-pushed
the
empty-group-by
branch
from
7a71827
to
5a87b10
Compare
Signed-off-by: Mark Sagi-Kazar <[email protected]>
tothandras
approved these changes
Feb 22, 2024
hekike
reviewed
Feb 22, 2024
| @@ -123,6 +123,11 @@ func (d createMeterView) toSQL() (string, []interface{}, error) { | |||
| orderBy := []string{"windowstart", "windowend", "subject"} | |||
| sortedGroupBy := sortedKeys(d.GroupBy) | |||
| for _, k := range sortedGroupBy { | |||
| // Skip empty keys | |||
| if k == "" { | |||
| continue | |||
There was a problem hiding this comment.
I would return error. I think from an operational perspective, it's better to be strict and surface issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Empty group bys lead to failing queries.