-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop name_en and name_de from the transportation layers #1474
Open
ZeLonewolf
wants to merge
8
commits into
openmaptiles:master
Choose a base branch
from
ZeLonewolf:zlw-drop-name-underscore-highway
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Drop name_en and name_de from the transportation layers #1474
ZeLonewolf
wants to merge
8
commits into
openmaptiles:master
from
ZeLonewolf:zlw-drop-name-underscore-highway
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results evaluating commit 531b0b5 (merged with base e61442c as 2e5dedd). See run details. PostgreSQL DB size in MB: 4939 ⇒ 4937 (-0.0% change)
expand for details...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to remove
name_en
andname_de
from the transportation_name layer. These values are deprecated in favor ofname:en
andname:de
which are imported via openmaptiles-tools. Thus, these legacy values are just extra code and space that isn't needed.If this PR is accepted, I intend to submit additional PRs to remove these from the other layers that use them.
Follow-on from #928