8331719: Cleanup asserts/code after introducing IsSTWGCActiveMark

[xiaotaonan]

Cleanup asserts/code after introducing IsSTWGCActiveMark

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331719: Cleanup asserts/code after introducing IsSTWGCActiveMark (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Guoxiong Li (@lgxbslgx - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19208/head:pull/19208
$ git checkout pull/19208

Update a local copy of the PR:
$ git checkout pull/19208
$ git pull https://git.openjdk.org/jdk.git pull/19208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19208

View PR using the GUI difftool:
$ git pr show -t 19208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19208.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xiaotaonan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331719: Cleanup asserts/code after introducing IsSTWGCActiveMark

Reviewed-by: stefank, gli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 1484153: 8332080: Update troff man page for javadoc
• 391bbbc: 8330584: IGV: XML does not save all node properties
• adaa509: 8327499: MethodHandleStatics.traceLambdaForm includes methods that cannot be generated
• 5a8df41: 8331535: Incorrect prompt for Console.readLine
• 3e3f7cf: 8330387: Crash with a different types patterns (primitive vs generic) in instanceof
• d517d2d: 8331764: C2 SuperWord: refactor _align_to_ref/_mem_ref_for_main_loop_alignment

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @lgxbslgx) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@xiaotaonan The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (74373a79)

[xiaotaonan]

@lgxbslgx

[xiaotaonan]

/signed

[bridgekeeper]

You are already a known contributor!

[lgxbslgx]

Looks good.

[lgxbslgx]

This issue was assigned by @shipilev . Not know whether he had a patch locally. It may be good for him to have a look.

[shipilev]

This issue was assigned by @shipilev . Not know whether he had a patch locally. It may be good for him to have a look.

Actually, this was assigned to one of our folks. The common courtesy protocol is to ask whether you can take the assignment off someone's hands. For many patches, there is a background that might only be known to current assignee, who might have done some further research into the issue.

For example here, I was planning to also deal with G1CollectedHeap::do_collection_pause_at_safepoint, which can be inlined better.

[lgxbslgx]

The common courtesy protocol is to ask whether you can take the assignment off someone's hands. For many patches, there is a background that might only be known to current assignee, who might have done some further research into the issue.

I agree. I think communication is more important than code/patch in an open source community.

@lgxbslgx

@xiaotaonan Generally, I will review the patches in HotSpot, especially GC, when I have free time. I am happy to review your patch. But I don't think it is good to CC me if I have not gotten involved in the discussion.

[xiaotaonan]

This issue was assigned by @shipilev . Not know whether he had a patch locally. It may be good for him to have a look.

Actually, this was assigned to one of our folks. The common courtesy protocol is to ask whether you can take the assignment off someone's hands. For many patches, there is a background that might only be known to current assignee, who might have done some further research into the issue.

For example here, I was planning to also deal with G1CollectedHeap::do_collection_pause_at_safepoint, which can be inlined better.

Sorry for that,I will close this PR.