New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332098: Add missing @ since tags to jdk.jdi #19200
Conversation
👋 Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into |
@nizarbenalla This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 34 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @plummercj) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@nizarbenalla The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
JPDA was added to the JDK in JDK 1.3. The support for pluggable connectors (added com.sun.jdi.connect.spi package) was JDK 5. So I think this looks okay. |
/integrate |
@nizarbenalla |
Can you fix the summary of the CR to not have backwards quotes. This seems to cause git some grief, as can be seen where the CR is mentioned in the Issue section of the PR description. |
Done, I tend to use them for formatting. |
/integrate |
@nizarbenalla |
@since
tags to jdk.jdi
No changes have been done to the PR since it was last approved by Chris few days back (that's a good thing). I'll go ahead and sponsor this now. |
/sponsor |
Going to push as commit a33cb90.
Your commit was automatically rebased without conflicts. |
@jaikiran @nizarbenalla Pushed as commit a33cb90. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this simple change where I add "@ since" tags to the package-info file of the following packages
com.sun.jdi
com.sun.jdi.connect
com.sun.jdi.connect.spi
com.sun.jdi.event
com.sun.jdi.request
I used the unix grep command to find the oldest "@ since" in each package and used that value, as it's hard to get the source code of JDK 1-5
TIA
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19200/head:pull/19200
$ git checkout pull/19200
Update a local copy of the PR:
$ git checkout pull/19200
$ git pull https://git.openjdk.org/jdk.git pull/19200/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19200
View PR using the GUI difftool:
$ git pr show -t 19200
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19200.diff
Webrev
Link to Webrev Comment