Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332072: Add package-info and @since to packages in java.naming #19199

Closed
wants to merge 1 commit into from

Conversation

nizarbenalla
Copy link
Contributor

@nizarbenalla nizarbenalla commented May 12, 2024

Please review this change where I added a package-info to the following packages, with an @since tags.

javax.naming
javax.naming.directory
javax.naming.event
javax.naming.ldap
javax.naming.spi
javax.naming.ldap.spi

TIA


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332072: Add package-info and @<!---->since to packages in java.naming (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19199/head:pull/19199
$ git checkout pull/19199

Update a local copy of the PR:
$ git checkout pull/19199
$ git pull https://git.openjdk.org/jdk.git pull/19199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19199

View PR using the GUI difftool:
$ git pr show -t 19199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19199.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2024

👋 Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 12, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 12, 2024

@nizarbenalla The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@AlanBateman
Copy link
Contributor

These packages already have a package.html file with @since 1.3. I'm surprised they haven't been migrated to a package-info.java.

@nizarbenalla
Copy link
Contributor Author

@AlanBateman I will close this #19198 and for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants