Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331429: [JVMCI] Cleanup JVMCIRuntime allocation routines #19176

Closed
wants to merge 3 commits into from

Conversation

mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented May 10, 2024

This PR removes allocation routines that may throw exception from JVMCIRuntime. It also exports various symbols related to the hashed secondary supers table.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331429: [JVMCI] Cleanup JVMCIRuntime allocation routines (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19176/head:pull/19176
$ git checkout pull/19176

Update a local copy of the PR:
$ git checkout pull/19176
$ git pull https://git.openjdk.org/jdk.git pull/19176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19176

View PR using the GUI difftool:
$ git pr show -t 19176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19176.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2024

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 10, 2024

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331429: [JVMCI] Cleanup JVMCIRuntime allocation routines

Reviewed-by: dlong, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • 2f10a31: 8302850: Implement C1 clone intrinsic that reuses arraycopy code for primitive arrays
  • c642f44: 8329839: Cleanup ZPhysicalMemoryBacking trace logging
  • d04ac14: 8332236: javac crashes with module imports and implicitly declared class
  • 4e77cf8: 8330795: C2: assert((uint)type <= T_CONFLICT && _zero_type[type] != nullptr) failed: bad type with -XX:-UseCompressedClassPointers
  • 7b4ba7f: 8325932: Replace ATTRIBUTE_NORETURN with direct [[noreturn]]
  • 0bb5ae6: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
  • 4d32c60: 8322008: Exclude some CDS tests from running with -Xshare:off
  • e91492a: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
  • 95a6013: 8332042: Move MEMFLAGS to its own include file
  • 5a4415a: 8331858: [nmt] VM.native_memory statistics should work in summary mode
  • ... and 28 more: https://git.openjdk.org/jdk/compare/242446b07fcfcac136510495d1ff16d26859aea4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dean-long, @dougxc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented May 10, 2024

@mur47x111 The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented May 10, 2024

Webrevs

@dougxc
Copy link
Member

dougxc commented May 10, 2024

Please also update InternalOOMEMark to remove support for thread being nullptr.

@openjdk openjdk bot removed the rfr Pull request is ready for review label May 13, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label May 13, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 13, 2024
@mur47x111
Copy link
Contributor Author

Thanks for the review!

@mur47x111
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

@mur47x111
Your change (at version 0a63852) is now ready to be sponsored by a Committer.

@dougxc
Copy link
Member

dougxc commented May 15, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented May 15, 2024

Going to push as commit 957eb61.
Since your change was applied there have been 38 commits pushed to the master branch:

  • 2f10a31: 8302850: Implement C1 clone intrinsic that reuses arraycopy code for primitive arrays
  • c642f44: 8329839: Cleanup ZPhysicalMemoryBacking trace logging
  • d04ac14: 8332236: javac crashes with module imports and implicitly declared class
  • 4e77cf8: 8330795: C2: assert((uint)type <= T_CONFLICT && _zero_type[type] != nullptr) failed: bad type with -XX:-UseCompressedClassPointers
  • 7b4ba7f: 8325932: Replace ATTRIBUTE_NORETURN with direct [[noreturn]]
  • 0bb5ae6: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
  • 4d32c60: 8322008: Exclude some CDS tests from running with -Xshare:off
  • e91492a: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
  • 95a6013: 8332042: Move MEMFLAGS to its own include file
  • 5a4415a: 8331858: [nmt] VM.native_memory statistics should work in summary mode
  • ... and 28 more: https://git.openjdk.org/jdk/compare/242446b07fcfcac136510495d1ff16d26859aea4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 15, 2024
@openjdk openjdk bot closed this May 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

@dougxc @mur47x111 Pushed as commit 957eb61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants