Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[samsungtv] Change codeowner #16784

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Conversation

NickWaterton
Copy link
Contributor

Update codeowner to @NickWaterton

Signed-off-by: Nick Waterton <[email protected]>
@jlaur
Copy link
Contributor

jlaur commented May 22, 2024

@paulianttila, would you no longer like to be a maintainer of this binding? Just to be sure.

@lsiepel
Copy link
Contributor

lsiepel commented May 22, 2024

@paulianttila, would you no longer like to be a maintainer of this binding? Just to be sure.

FTR: i proposed to add @NickWaterton as second codeowner.

@jlaur
Copy link
Contributor

jlaur commented May 22, 2024

@paulianttila, would you no longer like to be a maintainer of this binding? Just to be sure.

FTR: i proposed to add @NickWaterton as second codeowner.

Sure. I found these comments:

In the meantime, the binding was heavily rewritten during the last more than two years without any review comments/objections from @paulianttila, so I guess it would be logical to promote @NickWaterton as sole maintainer. It would still be nice with a confirmation from @paulianttila before doing so.

In any case - @kaikreuzer, can you add @NickWaterton to the contributor team?

@lsiepel
Copy link
Contributor

lsiepel commented May 31, 2024

Can you fix the conflict?

@lsiepel
Copy link
Contributor

lsiepel commented Jun 11, 2024

Can you fix the conflict?

Ping @NickWaterton

@NickWaterton
Copy link
Contributor Author

Can you fix the conflict?

Ping @NickWaterton

Sorry, didn't realize you were talking to me.

What are the conflicts? how would I resolve them? there is only one file edited.

@lsiepel
Copy link
Contributor

lsiepel commented Jun 14, 2024

Can you fix the conflict?

Ping @NickWaterton

Sorry, didn't realize you were talking to me.

What are the conflicts? how would I resolve them? there is only one file edited.

If you update your fork main branch, and then your feature branch. You will get a notice about the conflict.

@NickWaterton NickWaterton reopened this Jun 14, 2024
@NickWaterton
Copy link
Contributor Author

Can you fix the conflict?

Ping @NickWaterton

Sorry, didn't realize you were talking to me.
What are the conflicts? how would I resolve them? there is only one file edited.

If you update your fork main branch, and then your feature branch. You will get a notice about the conflict.

Ok,

I tried. I still don't know what the conflict was, or if this has resolved it.

CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 18d3d5b into openhab:main Jun 14, 2024
3 of 5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Jun 14, 2024
@lsiepel lsiepel changed the title [samsungtv] documentation change codeowner [samsungtv] Change codeowner Jun 14, 2024
@NickWaterton NickWaterton deleted the samsungtv-codeowner branch June 14, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants