Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat#701 #923

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feat#701 #923

wants to merge 4 commits into from

Conversation

baymax55
Copy link
Contributor

@baymax55 baymax55 commented Nov 7, 2022

Fixes #701

使用qq,163,gmail作为发送邮件服务测试正常

改用freemarker和spring-boot-starter-mail实现

@pirme
Copy link
Member

pirme commented Nov 7, 2022

可以放几张效果图

@baymax55
Copy link
Contributor Author

baymax55 commented Nov 7, 2022

image

image

@pirme

@pirme
Copy link
Member

pirme commented Nov 7, 2022

是不是可以把通知和报警类型的 Title 替换为内容的第一行,因为当前的 Title 容易抓不到重点

@iwangjie
Copy link
Member

请考虑将邮件标题变更为类似如下几种

  1. 【${env}】${thread_pool_name} 线程池 ${type} 预警
  2. 【Hippo4J】${env}-${thread_pool_name} 线程池 ${type} 预警
  3. 【${env}-${app_name}】${thread_pool_name} 线程池 ${type} 预警
    因为平时邮件较多,一目了然的话可能能节省用户更多的时间!

@baymax55
Copy link
Contributor Author

请考虑将邮件标题变更为类似如下几种

  1. 【${env}】${thread_pool_name} 线程池 ${type} 预警
  2. 【Hippo4J】${env}-${thread_pool_name} 线程池 ${type} 预警
  3. 【${env}-${app_name}】${thread_pool_name} 线程池 ${type} 预警
    因为平时邮件较多,一目了然的话可能能节省用户更多的时间!

好的,我改下标题

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 24.72% // Head: 26.68% // Increases project coverage by +1.95% 🎉

Coverage data is based on head (8d069c9) compared to base (59cb0b2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #923      +/-   ##
=============================================
+ Coverage      24.72%   26.68%   +1.95%     
- Complexity       577      667      +90     
=============================================
  Files            239      244       +5     
  Lines           5468     5738     +270     
  Branches         494      514      +20     
=============================================
+ Hits            1352     1531     +179     
- Misses          3995     4059      +64     
- Partials         121      148      +27     
Impacted Files Coverage Δ
...n/hippo4j/message/config/MessageConfiguration.java 0.00% <0.00%> (ø)
...a/cn/hippo4j/message/enums/NotifyPlatformEnum.java 0.00% <0.00%> (ø)
...po4j/message/platform/EmailSendMessageHandler.java 0.00% <0.00%> (ø)
...message/platform/constant/EmailAlarmConstants.java 0.00% <0.00%> (ø)
...main/java/cn/hippo4j/rpc/support/ResultHolder.java 57.89% <0.00%> (-42.11%) ⬇️
.../cn/hippo4j/rpc/exception/ConnectionException.java 0.00% <0.00%> (-20.00%) ⬇️
.../java/cn/hippo4j/rpc/support/NettyProxyCenter.java 57.44% <0.00%> (-17.56%) ⬇️
.../hippo4j/core/plugin/impl/TaskDecoratorPlugin.java 80.00% <0.00%> (-14.12%) ⬇️
.../java/cn/hippo4j/rpc/support/NettyConnectPool.java 66.66% <0.00%> (-13.89%) ⬇️
...j/core/handler/DynamicThreadPoolBannerHandler.java 0.00% <0.00%> (-13.34%) ⬇️
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@baymax55
Copy link
Contributor Author

配置变更

image

报警通知

image

@iwangjie @pirme

@magestacks
Copy link
Member

看代码实现方面已经没有问题了,我需要考虑下邮箱配置接入以及如何打通 Server 模式,会花些时间,请稍等。

@baymax55
Copy link
Contributor Author

看代码实现方面已经没有问题了,我需要考虑下邮箱配置接入以及如何打通 Server 模式,会花些时间,请稍等。
好的,大佬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support mailbox type parameter change and alarm notification.
4 participants