Fix TextField behaviour wrt stopPropagation() #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes stopPropagation() behaviors
|
@MSGhero could you have a look at this PR? This change makes the behaviour of text fields closer to what we have in flash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextFields should listen to stage events at the capture phase to ensure correct behaviour of text inputs when user code calls stopPropagation() in the event's target phase.
This PR is ready to be merged if this makes sense to you. It fixes the common situation where the parent of a text input stops the propagation of mouse up events, leading the text to be continuously in "selection mode", whereas in Flash it would still catch mouse inputs.