Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ManagerWebHookPort ManagerMetricAddr ManagerReadlineAddr in const… and update Dockerfile #308

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add ManagerWebHookPort ManagerMetricAddr ManagerReadlineAddr in const… and update Dockerfile #308

wants to merge 3 commits into from

Conversation

hurricane1988
Copy link

…ant.go, and use them in generic.go

Description

What type of PR is this ?:

Related links:

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hurricane1988
To complete the pull request process, please assign zheng1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zheng1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hurricane1988
To complete the pull request process, please assign zheng1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zheng1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2022
@hurricane1988
Copy link
Author

@zheng1 could you review my pull request please?

@renyunkang
Copy link
Member

@zheng1 could you review my pull request please?

Thank you very much for your contribution, can you fix the check according to the prompt.

@hurricane1988
add ManagerWebHookPort ManagerMetricAddr ManagerReadlineAddr in const…
e0b6710 
…ant.go, and use them in generic.go

Signed-off-by: hurricane1988 <[email protected]>
@hurricane1988
Copy link
Author

@zheng1 could you review my pull request please?

Thank you very much for your contribution, can you fix the check according to the prompt.

I really don't know what's that mean?

@chaunceyjiang
Copy link
Contributor

please refer to DCO

@hurricane1988
Copy link
Author

please refer to DCO

image

how about now? @chaunceyjiang

@chaunceyjiang
Copy link
Contributor

chaunceyjiang commented Sep 7, 2022 •
edited

how about now? @chaunceyjiang

image

see here

@hurricane1988
Copy link
Author

how about now? @chaunceyjiang

image

see here

@chaunceyjiang is there a wechat group of the openelb project?

@chaunceyjiang
Copy link
Contributor

@chaunceyjiang is there a wechat group of the openelb project?

@hurricane1988 you can add my WeChat(chauncey187) , I invite you

@renyunkang
Copy link
Member

/LGTM

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 046a8a750725cc06fc6ee5e3e407a2194f45dce5

1 similar comment
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 046a8a750725cc06fc6ee5e3e407a2194f45dce5

chaunceyjiang
chaunceyjiang reviewed Sep 21, 2022
View reviewed changes
Dockerfile
RUN GO111MODULE=on CGO_ENABLED=0 go install -i -ldflags '-w -s' github.com/openelb/openelb/cmd/...
RUN GO111MODULE=on CGO_ENABLED=0 go install -i -ldflags '-w -s' github.com/osrg/gobgp/cmd/gobgp
RUN GO111MODULE=on CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GOARM=6 go install -i -ldflags '-w -s' github.com/openelb/openelb/cmd/...
RUN GO111MODULE=on CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GOARM=6 go install -i -ldflags '-w -s' github.com/osrg/gobgp/cmd/gobgp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that GOARM is only effective when GOARCH is arm64.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell me why you only set GOARCH to amd64?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, we are no longer using this DockerFile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaunceyjiang chaunceyjiang chaunceyjiang left review comments

@renyunkang renyunkang Awaiting requested review from renyunkang

Assignees

@renyunkang renyunkang

Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hurricane1988 @ks-ci-bot @renyunkang @chaunceyjiang