Add cv::resize to copyFromOV to fix gaze_estimation_demo with API2.0 #24791
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DariaMityagina
commented
Dec 28, 2023
| if (tensor.get_size() != total) { | ||
| GAPI_LOG_WARNING(NULL, "copyToOV :: tensor.get_size() != total, resizing cv::Mat"); | ||
| auto W = ov::layout::width_idx("NHWC"); | ||
| auto H = ov::layout::height_idx("NHWC"); |
There was a problem hiding this comment.
TODO: It might be worth checking the layout here.
There was a problem hiding this comment.
This function is just copy. A dedicated preprocessing routine must be somewhere near (and resize should be already a part of it). @TolyaTalamanov for your consideration
There was a problem hiding this comment.
There was a problem hiding this comment.
So the real question is... Why the tensor is 1183x490 and the mat is 1180x490? They both are 3-channel.
There was a problem hiding this comment.
Sure, I keep looking for other option. This is just one of them.
Thanks a lot!
6 tasks
asmorkalov
requested review from
dmatveev and
TolyaTalamanov
and removed request for
dmatveev
|
@dmatveev @TolyaTalamanov Friendly reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Related PRs:
openvinotoolkit/open_model_zoo#3887
gaze_estimation_demo_gapiOK: Works with a single image and with a video input.
FAIL: But still has issues in case folder with images is provided (in CI) - WIP
Failed to copy data from cv::Mat to ov::Tensor. Data type or number of elements mismatch. ov::Tensor: u8 [1,490,1183,3] and cv::Mat: 8UC3 1180x490It seems to fail if the input folder contains images of different sizes. It works fine with the first image from the folder and does not work with the second (if it has a different size).