You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattray
added
opencost
OpenCost issues vs. external/downstream
P1
Estimated Priority (P0 is highest, P4 is lowest)
kubecost
Relevant to Kubecost's downstream project
E1
Estimated level of Effort (1 is easiest, 4 is hardest)
labels
Feb 8, 2024
@namm2 Good catch! I've confirmed the other providers have this set to zero. @opencost/opencost-maintainers any reason this may have been set differently?
Historically, we've set this to 30% intentionally to match GCP's sustained use discount. Maybe product wants to chime in with regard to the best decision here. Do we assume sustained use or not? Or, even if we do assume sustained use, should we put the onus on the user to set this discount themselves?
AFAIU, SUD discount is variable based on the %usage and machine type (hence up to 30%) then the static value 30% is still not correct out-of-the-box. Also there's another Commited Use Discount which is variable too, I'd leave it to users to set their discount value than hard code it.
This pull request has been marked as stale because it has been open for 90 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days.
We just take an average 30% discount because this is meant to be an estimate. This is user configurable so I'm not sure there's a compelling reason to change this right now.
We just take an average 30% discount because this is meant to be an estimate. This is user configurable so I'm not sure there's a compelling reason to change this right now.
Yes it's configurable but I mean the default value should be 0% like other cloud providers, and it's up to end users to set this.
E1Estimated level of Effort (1 is easiest, 4 is hardest)kubecostRelevant to Kubecost's downstream projectneeds-follow-upopencostOpenCost issues vs. external/downstreamP1Estimated Priority (P0 is highest, P4 is lowest)
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?