Invalidate cached user on changes #5843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain circumstances, you may want to configure multiple authentication mechanisms in Opencast, but with the same user source. For example, a user should be able to log in using Shibboleth and also using JWT from an external trusted application. In this case, the user roles should be merged. This is handled correctly by Opencast. User data is then cached for performance reasons. However, on the first request using a different login mechanism, the user details should be set correctly, but the old cached user details are used instead. All subsequent requests are fine. This patch should fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain circumstances, you may want to configure multiple authentication mechanisms in Opencast, but with the same user source. For example, a user should be able to log in using Shibboleth and also using JWT from an external trusted application. In this case, the user roles should be merged. This is handled correctly by Opencast. User data is then cached for performance reasons. However, on the first request using a different login mechanism, the user details should be set correctly, but the old cached user details are used instead. All subsequent requests are fine. This patch should fix that.
Your pull request should…