Reduce memory allocations and simplify the mbmem loop #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The collect_multiboot_info function allocates memory for mmap using malloc. Depending on the size of the multiboot_mmap array, this could be a lot of memory. Instead, a stack-allocated array or a pre-allocated buffer to store the mmap data would work perfectly and the mbmem loop that converts the mmap records is somewhat complex and difficult to follow.