Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix embedding model change and quick code edits #1103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ankur-oai
Copy link
Contributor

@ankur-oai ankur-oai commented Mar 13, 2024

Summary

This PR bulk-updated older model names and changed this notebook to use text-embedding-3-small but broke it in the process; this notebook relies on comparisons b/w a query string embedding against data from a CSV in our CDN that contains vectors generated with ada-002.

Also:

  • removed some unused variables
  • removed an empty code block at the end of the notebook

Motivation

Why are these changes necessary? How do they improve the cookbook?

Cookbook was not working as expected (bad embedding query results).


For new content

When contributing new content, read through our contribution guidelines, and mark the following action items as completed:

  • I have added a new entry in registry.yaml (and, optionally, in authors.yaml) so that my content renders on the cookbook website.
  • I have conducted a self-review of my content based on the contribution guidelines:
    • Relevance: This content is related to building with OpenAI technologies and is useful to others.
    • Uniqueness: I have searched for related examples in the OpenAI Cookbook, and verified that my content offers new insights or unique information compared to existing documentation.
    • Spelling and Grammar: I have checked for spelling or grammatical mistakes.
    • Clarity: I have done a final read-through and verified that my submission is well-organized and easy to understand.
    • Correctness: The information I include is correct and all of my code executes successfully.
    • Completeness: I have explained everything fully, including all necessary references and citations.

We will rate each of these areas on a scale from 1 to 4, and will only accept contributions that score 3 or higher on all areas. Refer to our contribution guidelines for more details.

@sarbazvatanatan
Copy link

Very good

@sarbazvatanatan
Copy link

Hard

@sarbazvatanatan
Copy link

  1. Hdcj

@sarbazvatanatan
Copy link

Hoo

@sarbazvatanatan
Copy link


This was referenced Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants