fix: chatgpt-web #1503
Open
fix: chatgpt-web #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChatGPT Web now utilizes WebSocket for data transmission.
|
Thank you for your contribution, it seems there are some code conflicts that need to be resolved. |
|
Thanks for the reminder. I've already resolved the conflicts, but I'm having trouble understanding the Lint errors that came up and don't know how to fix them. |
iI had to modify the eslint config and set /* eslint-disable prettier/prettier */ in the settings and translator components because otherwise, I would encounter prettier/prettier errors that I didn't understand. I hope you can review this portion of the code and make appropriate modifications.
yetone
reviewed
May 7, 2024
| @@ -193,7 +192,7 @@ export class QuoteProcessor { | |||
|
|
|||
| const chineseLangCodes = ['zh-Hans', 'zh-Hant', 'lzh', 'yue', 'jdbhw', 'xdbhw'] | |||
|
|
|||
| export async function translate(query: TranslateQuery) { | |||
| export async function translate(query: TranslateQuery, engine: IEngine | undefined) { | |||
There was a problem hiding this comment.
Why is this engine singled out?
There was a problem hiding this comment.
Because maintaining a long-term connection is necessary when using WebSockets, we don't have to re-register the WebSocket every time a request is made. To ensure the WebSocket's long-term existence, we need a long-term existing engine, rather than generating a new engine every time the translate function is used, as was done previously.
|
Any progress? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChatGPT Web now utilizes WebSocket for data transmission.