Move configuration methods to class methods #16164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to retrieve the values stored in the singleton record of the table
configurations
in the database for none of theldap_enabled?
,proxy_auth_mode_enabled?
andamqp_namespace
methods.Moving each method to the class methods section prevents from performing unneeded database queries.
For reviewers
Before
Taking the
home:Admin
project page as an example, browsing http://localhost:3000/project/show/home:Admin and taking a look at the frontend log resulted in:After
Browsing http://localhost:3000/project/show/home:Admin resulted in: