Regexes: Sanitize user input #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
force-pushed
the
fix-escape-regexes
branch
2 times, most recently
from
6cb9267
to
8d1af78
Compare
franzpoeschel
force-pushed
the
fix-escape-regexes
branch
from
8d1af78
to
16448a3
Compare
franzpoeschel
commented
Jun 11, 2024
ax3l
reviewed
Jun 11, 2024
src/Series.cpp
Outdated
Comment on lines
3054
to
3058
| auto sanitize_regex(std::string const &input) -> std::string | ||
| { | ||
| std::regex specialChars{R"([-[\]{}()*+?.,\^$|#\s])"}; | ||
| return std::regex_replace(input, specialChars, R"(\$&)"); | ||
| } |
There was a problem hiding this comment.
for more information, see https://pre-commit.ci
ax3l
reviewed
Jun 11, 2024
ax3l
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detecting files of file-based encoding, we use Regexes and emplace user input into them. This might lead to Regex injection when the file name contains a special character, e.g.
openpmd-ls simData_+10_1_%T.bp5. Fix that.