Enable multithreading when numThreads == 0. #2216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmoulon
reviewed
Jul 6, 2023
| @@ -260,7 +260,8 @@ int main(int argc, char **argv) | |||
| if (iNumThreads > 0) { | |||
There was a problem hiding this comment.
Would not be better to have the value iNumThreads updated once with a IF, and then call once omp_set_num_threads(iNumThreads);
There was a problem hiding this comment.
I thought about this, but the initial iNumThreads could be negative, in which case wouldn't want to call omp_set_num_threads()? I'm not sure what the effect would be, and so this seems like the safest change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like multiple people have encountered this bug where the CPU is only 100% on the compute features stage.
#2198 #1730
After applying the change from #1730 (comment) it worked for me as well.