Add Incremental Matching #1091
Open
Add Incremental Matching #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add function to filter out pairs of views when both views are already present in the computed matches
- Edit force flag to add incremental matching - Add incremental matching, it computes matches only between views that are not both already present in computed matches
Fix variable type from size_t to const IndexT to make it compliant with the convention adopted
|
Thx. Seems like it does not compiles on Unix: |
|
You are right, I actually forgot to commit a change. |
|
No worries, the continuous integration is here to check that (safe compilation and unit test launching). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I add the possibility to compute the matches incrementally.
It starts from a set of matches, otherwise it just computes all of them, and from them it computes the missing ones.
A match is computed only if at least one of the two views involved is not present in any of the pre-computed match.