[UPF] Don't restore invalid PDR teid during restoration #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mitmitmitm If the PDR has a TEID, it will not have a CH, but I don't know if we need this code to check for that. |
acetcom
added
the
type:wontfix
|
@mitmitmitm If the PDR has a TEID, it will not have a CH,
Yup, and inversely, if a PDR has a CH, it doesn't have a TEID. It is
therefore invalid to call function |ogs_pfcp_pdr_swap_teid(pdr)| which
operates on |pdr->f_teid.teid|.
I guess we could also add something like
…--- a/lib/pfcp/context.c
+++ b/lib/pfcp/context.c
@@ -1139,6 +1139,7 @@
int i = 0;
ogs_assert(pdr);
+ ogs_assert(!pdr->f_teid.ch);
ogs_assert(pdr->f_teid.teid > 0 &&
pdr->f_teid.teid <= ogs_pfcp_pdr_teid_pool.size);
|
|
This can cause UPF to stop running. In my opinion, it is preferable to implement proper exception handling. |
f_teid with ch set doesn't have valid teid set at this point.
mitmitmitm
force-pushed
the
upf-restoration-pdr-teid-ch
branch
from
6c880b9
to
cbdab68
Compare
|
What I meant was to add the assertion in addition to this pull request.
In any case, I've updated this pull request. It now includes a check to
prevent teid swapping in case of 'ch' bit set. And the assertion to
document that teid must not be swapped for PDR's with 'ch' bit set.
|
|
As there has been no recent activity on this PR, it has been marked as stale. It will be automatically closed if no further action is taken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f_teid with ch bit set doesn't have a valid teid at this point.