feat: clean up trace SDK APIs #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
May 14, 2024
TommyCpp
force-pushed
the
zhongyang/close-sdk-APIs
branch
from
2b94e6c
to
13bde88
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1755 +/- ##
=====================================
Coverage 74.4% 74.4%
=====================================
Files 122 122
Lines 19807 19800 -7
=====================================
Hits 14750 14750
+ Misses 5057 5050 -7 ☔ View full report in Codecov by Sentry. |
TommyCpp
changed the title
cijothomas
reviewed
May 28, 2024
cijothomas
reviewed
May 28, 2024
|
I think this update to opentelemetry-proto submodule is not intended, as we are already using the latest version :) |
TommyCpp
force-pushed
the
zhongyang/close-sdk-APIs
branch
from
2d64b24
to
683ec99
Compare
cijothomas
reviewed
May 29, 2024
opentelemetry-sdk/CHANGELOG.md
Outdated
| @@ -61,13 +65,7 @@ | |||
| - After `shutdown`, `LogProcessor` will not process any new logs | |||
| - Moving LogRecord implementation to the SDK. [1702](https://github.com/open-telemetry/opentelemetry-rust/pull/1702). | |||
| - Relocated `LogRecord` struct to SDK, as an implementation for the trait in the API. | |||
| - **Breaking** [#1729](https://github.com/open-telemetry/opentelemetry-rust/pull/1729) | |||
There was a problem hiding this comment.
we cannot remove this as it is already part of shipped code!
cijothomas
approved these changes
May 29, 2024
lalitb
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes