Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support fedora in kernel header install script #262

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tsloughter
Copy link
Member

Description:

Fixes #261 by supporting fedora in the kernel header install script

Link to tracking Issue:

#261

Testing:

Working on manual testing, currently stuck trying to build opentelemetry-ebpf-build-tools because it "freezes" on Cloning into '/home/tristan/Devel/opentelemetry-ebpf-build-tools/gcp_cpp/google-cloud-cpp'...

I was also going to add to the CI tests but was getting confused hoping around shell scripts. If anyone can help explain what needs to be updated there I'd be happy to add fedora to the distros tested against if its desired.

Documentation:

None. It doesn't appear there are any docs about what hosts are supported, so if wanted I can add a list of supported distros to https://github.com/open-telemetry/opentelemetry-network/blob/main/docs/kernel-collector.md, not sure if anywhere else would be appropriate to add that info?

@yonch
Copy link
Contributor

yonch commented Apr 15, 2024

Working on manual testing, currently stuck trying to build opentelemetry-ebpf-build-tools because it "freezes" on Cloning into '/home/tristan/Devel/opentelemetry-ebpf-build-tools/gcp_cpp/google-cloud-cpp'...

Could the problem be related to this issue?

Documentation:

None. It doesn't appear there are any docs about what hosts are supported, so if wanted I can add a list of supported distros to https://github.com/open-telemetry/opentelemetry-network/blob/main/docs/kernel-collector.md, not sure if anywhere else would be appropriate to add that info?

Yes! It's important enough to add to the main project README, IMO. Happy to review a PR!

@yonch
Copy link
Contributor

yonch commented Apr 15, 2024

I was also going to add to the CI tests but was getting confused hoping around shell scripts. If anyone can help explain what needs to be updated there I'd be happy to add fedora to the distros tested against if its desired.

@samiura @atoulme any pointers you can share?

@yonch
Copy link
Contributor

yonch commented Apr 15, 2024

I took a look at the Github Actions result for this branch, looks like it is indeed similar to the problem in #256

@tsloughter
Copy link
Member Author

Yes! It's important enough to add to the main project README, IMO. Happy to review a PR!

Alright, will do!

@kubakukis14
Copy link

kubakukis14 commented Apr 16, 2024

Hey there! I faced a similar problem with freezing while building the build-env on fedora. I've had 2 problems when building:
The first one may be relevant if you are using docker desktop. I had to swap from the "linux-desktop" (or somesuch, it had "linux" in the name) to just "docker" in the builder settings. Docker desktop defaults to this builder and you have to switch manually in the app and run systemctl start docker. I have no idea why, but it resolved the issue for me.

The second one was that I just ran out of RAM. My system has 32 gigs and I had to mount additional swap memory for it to be able to handle the build (it took about 9 more gigs of swap at most).

Hope this can help you with getting it running @tsloughter !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fedora not supported by header install script
3 participants