Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Events SDK #4629

Merged
merged 33 commits into from
Jun 5, 2024
Merged

add Events SDK #4629

merged 33 commits into from
Jun 5, 2024

Conversation

martinkuba
Copy link
Contributor

@martinkuba martinkuba commented Apr 11, 2024

Which problem is this PR solving?

This adds an experimental implementation of the Events SDK.

As a related update, I have also updated the Events API with the following:

  • replaced traceId and spanId fields in the Event interface with context field (see spec)
  • added severityNumber field

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@martinkuba martinkuba requested a review from a team as a code owner April 11, 2024 19:33
Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I added a few non-blocking suggestions to make it easier for someone to try it out. I also added a note about setting a default severityNumber of 9 based on the spec.

experimental/packages/sdk-events/src/EventLogger.ts Outdated Show resolved Hide resolved
experimental/examples/events/index.ts Show resolved Hide resolved
experimental/examples/events/README.md Outdated Show resolved Hide resolved
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, looks good overall 👍

experimental/packages/sdk-events/package.json Outdated Show resolved Hide resolved
experimental/examples/events/package.json Outdated Show resolved Hide resolved
experimental/packages/sdk-events/src/EventLogger.ts Outdated Show resolved Hide resolved
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request May 23, 2024
This adds details to how EventLoggerProvider and EventLogger should be
implemented in the default Events SDK.

Prototypes
- [JavaScript
prototype](open-telemetry/opentelemetry-js#4629)
- [Java
prototype](https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk/logs/src/main/java/io/opentelemetry/sdk/logs/internal/SdkEventLoggerProvider.java)
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.82%. Comparing base (ecc88a3) to head (1e6d89f).
Report is 12 commits behind head on main.

Current head 1e6d89f differs from pull request most recent head 87ad9bc

Please upload reports for the commit 87ad9bc to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4629      +/-   ##
==========================================
+ Coverage   91.04%   93.82%   +2.78%     
==========================================
  Files          89      240     +151     
  Lines        1954     5606    +3652     
  Branches      416     1125     +709     
==========================================
+ Hits         1779     5260    +3481     
- Misses        175      346     +171     

see 153 files with indirect coverage changes

@pichlermarc pichlermarc added this pull request to the merge queue Jun 5, 2024
Merged via the queue into open-telemetry:main with commit 7c808e3 Jun 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants