[pkg/ottl] Add minute converter #33200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds in a converter to pull the minute component out of a `time.Time`. Signed-off-by: sinkingpoint <[email protected]>
Signed-off-by: sinkingpoint <[email protected]>
sinkingpoint
requested review from
TylerHelmuth,
bogdandrutu,
evan-bradley and
a team
as code owners
TylerHelmuth
approved these changes
May 28, 2024
TylerHelmuth
added
the
ready to merge
evan-bradley
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds in a Minute converter that takes a time.Time and returns the int minute component. Analogous to what we already have with Hour
Link to tracking Issue: #33106
Testing: Added two unit tests based on the existing Hour ones
Documentation: Added the new converter to the ottlfuncs README.md