-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azureeventhubreceiver] Migrate to new AzureSDK #33134
Draft
nslaughter
wants to merge
33
commits into
open-telemetry:main
Choose a base branch
from
nslaughter:nslaughter/migrate-azure-sdk-for-eventhub
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[azureeventhubreceiver] Migrate to new AzureSDK #33134
nslaughter
wants to merge
33
commits into
open-telemetry:main
from
nslaughter:nslaughter/migrate-azure-sdk-for-eventhub
+492
−302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change the concurrent case was broken for some reason. Regardless, the divergence in paths used is the approach strongly recommended by the SDK docs.
06d3388
to
e785643
Compare
85c2d0a
to
9bf9c12
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
cparkins
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a great addition. Once the build is fixed I think this is ready to go from my perspective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/configschema
configschema command
cmd/githubgen
cmd/otelcontribcol
otelcontribcol command
cmd/oteltestbedcol
cmd/telemetrygen
telemetrygen command
confmap/provider/s3provider
connector/datadog
examples/demo
exporter/alibabacloudlogservice
Alibaba components
exporter/awscloudwatchlogs
awscloudwatchlogs exporter
exporter/awsemf
awsemf exporter
exporter/awskinesis
exporter/awss3
exporter/awsxray
exporter/azuremonitor
exporter/datadog
Datadog components
exporter/googlecloudpubsub
exporter/kafka
exporter/loadbalancing
exporter/otelarrow
exporter/sentry
exporter/signalfx
pkg/translator/azure
receiver/activedirectoryds
receiver/azureblob
receiver/azureeventhub
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is an enhancement to the
azureeventhubreceiver
, which migrates code to use the current library as recommended by Azure in the SDK migration guide for EventHubs in Go.azureeventhubreceiver
was initially developed whenazure-event-hubs-go
was the preferred package. This has superseded by theazeventhubs
package in theAzure/azure-sdk-for-go
repo. See the migration guide for the package.Link to tracking Issue: #31252
Testing: Unit tests are updated and I have done some manual testing in development with Azure payloads.
Documentation: No additional documentation as there's no change for Collector users.