Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing entry of 'isthing' for coco panoptic in customize dataset #11487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FranklynJey
Copy link

@FranklynJey FranklynJey commented Feb 21, 2024

Motivation

I created a customized dataset for coco panoptic segmentation by following mmdetection/docs/en/advanced_guides/customize_dataset.md.

In the description, we can find

categories': [  # including both foreground categories and background categories
    {'id': 0, 'name': 'person'},
    ...

A dataset created like this will cause errors, as the attribute 'isthing' is required. I first realized it in browse_dataset.py which breaks using the panoptic coco dataset format according to customized_dataset.md.

See

Screenshot from 2024-02-21 12-05-00

This holds even if metainfo is defined as

metainfo = dict(
        classes = ('class1','class2',... ),
        thing_classes = ('class1',... ),
        stuff_classes = ('class2',...)
        )

and is given to train_dataloader etc.

Modification

I would recommend changing the line

categories': [  # including both foreground categories and background categories
    {'id': 0, 'name': 'person'},

to

categories': [  # including both foreground categories and background categories
    {'id': 0, 'name': 'person', 'isthing': 1},

so that it matches the original coco panoptic description and prevents errors in mmdetection.

PS

Thank you guys so much for your awesome work in mmdetection!

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Feb 21, 2024

CLA assistant check
All committers have signed the CLA.

@FranklynJey
Copy link
Author

@jbwang1997 did you have time to look on it ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants