Add missing entry of 'isthing' for coco panoptic in customize dataset #11487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I created a customized dataset for coco panoptic segmentation by following mmdetection/docs/en/advanced_guides/customize_dataset.md.
In the description, we can find
A dataset created like this will cause errors, as the attribute 'isthing' is required. I first realized it in browse_dataset.py which breaks using the panoptic coco dataset format according to customized_dataset.md.
See
This holds even if metainfo is defined as
and is given to train_dataloader etc.
Modification
I would recommend changing the line
to
so that it matches the original coco panoptic description and prevents errors in mmdetection.
PS
Thank you guys so much for your awesome work in mmdetection!
Checklist