Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Mismatch Between bboxes and scores During NMS in Confusion Matrix Calculation #11462

Open
wants to merge 1 commit into
base: dev-3.x
Choose a base branch
from

Conversation

mochiriku
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

When running NMS within the calculate_confusion_matrix function, there is a bug where det_scores is not reduced even if det_bboxes is reduced.
The goal it to fix this bug.

Modification

Instead of overwriting det_bboxes with the output (concatenation of det_bboxes and det_scores) of the function nms, I modified it to store the output in dets once and then split it into det_bboxes and det_scores.
This allows det_scores to match det_bboxes.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2024

CLA assistant check
All committers have signed the CLA.

@hhaAndroid hhaAndroid changed the base branch from main to dev-3.x February 23, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants