-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: trino integration test #16291
Conversation
- removed "helpers" as its being used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
- remove intermediate containers
@@ -324,6 +324,7 @@ | |||
"minio==7.2.5", | |||
*plugins["mlflow"], | |||
*plugins["datalake-s3"], | |||
"requests==2.31.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be good to revert this https://github.com/open-metadata/OpenMetadata/pull/16365/files#diff-51c0c123b825b1c331fadd475a97dd0783282959ae7822a4b3993fe7dd09ab8dR111
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the pinning on base and kept this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah fair enough
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
@@ -324,6 +324,7 @@ | |||
"minio==7.2.5", | |||
*plugins["mlflow"], | |||
*plugins["datalake-s3"], | |||
"requests==2.31.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah fair enough
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>