S23 azure #177
S23 azure #177
Conversation
keting-ai
force-pushed
the
s23-azure
branch
from
21284c4
to
68ac754
Compare
| @@ -164,19 +164,40 @@ func create_lambdas(ctx *cli.Context) error { | |||
|
|
|||
| // simple pandas operation (correlation between two columns in 1000x10 DataFrame) | |||
| path = filepath.Join(common.Conf.Registry, fmt.Sprintf("bench-pd-%d.py", i)) | |||
| code = `# ol-install: numpy,pandas | |||
| code = `# ol-install: numpy,pandas,matplotlib,scipy | |||
There was a problem hiding this comment.
I don't want to repurpose the existing benchmark. Can you add a new one if needed?
| @@ -112,6 +115,15 @@ func randomString() string { | |||
| return strconv.Itoa(r.Int()) | |||
| } | |||
|
|
|||
| func AzureCreateVM(worker *Worker) (*AzureConfig, error) { | |||
| subscriptionId = os.Getenv("AZURE_SUBSCRIPTION_ID") | |||
There was a problem hiding this comment.
shouldn't this be part of the config file instead of an environment variable?
|
|
||
| new_vm.Subnet = *subnet | ||
|
|
||
| /* |
There was a problem hiding this comment.
don't leave in commented out code
|
|
||
| new_disk, err := createDisk(ctx, conn, *snapshot.ID, newDiskName) | ||
| if err != nil { | ||
| log.Print(err) |
There was a problem hiding this comment.
instead of printing each time, maybe its better for the caller to print this?
| log.Println(err.Error()) | ||
| return conf, err | ||
| } | ||
| create_lock.Unlock() |
There was a problem hiding this comment.
won't it be left locked if an error is returned? Can you find a better way, probably using the defer unlock pattern?
| } | ||
| } | ||
|
|
||
| var conf_lock sync.Mutex |
There was a problem hiding this comment.
does this need to be global, and shared across pools? Or should it be part of the pool?
|
|
||
| // TODO: Rightnow we default to have only one resource group | ||
| type rgroups struct { |
There was a problem hiding this comment.
does this type add anything useful beyond a regular slice of rgroup's?
| if err != nil { | ||
| log.Fatalf(err.Error()) | ||
| } | ||
| if pool.platform == "gcp" { |
There was a problem hiding this comment.
why do we need different logic for these two? Can we handle errors consistently?
| @@ -339,7 +353,12 @@ func (w *Worker) runCmd(command string) { | |||
|
|
|||
| tries := 10 | |||
| for tries > 0 { | |||
| sshcmd := exec.Command("ssh", user.Username+"@"+w.workerIp, "-o", "StrictHostKeyChecking=no", "-C", cmd) | |||
| var sshcmd *exec.Cmd | |||
There was a problem hiding this comment.
it feels like we should have a generic ssh-with-retry kind of function used by both platforms
| } | ||
|
|
||
| func LoadDefaults() error { | ||
| Conf = &Config{ | ||
| Platform: "mock", | ||
| Scaling: "manual", | ||
| API_key: "abc", // TODO: autogenerate a random key | ||
| API_key: "abc", // TODO |
There was a problem hiding this comment.
why are you deleting the more detailed comment?
The azure part of s23 works