Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new 2D advection diffusion example incl. comparison against Trixi.jl #427

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

Kojec1
Copy link
Collaborator

@Kojec1 Kojec1 commented Jun 4, 2024

No description provided.

@Kojec1 Kojec1 closed this Jun 4, 2024
@Kojec1 Kojec1 reopened this Jun 4, 2024
@slayoo
Copy link
Member

slayoo commented Jun 4, 2024

TODO:

  • share simulation setting between Trixi.jl and PyMPDATA (e.g., through a common JSON file created in the notebook)
  • save Julia simulation output to a file
  • compare simulation output
  • add Colab/Mybinder badges to the notebook header cell (as in other example notebooks in the repo)

@slayoo slayoo changed the title Added advection diffusion example new 2D advection diffusion example incl. comparison against Trixi.jl Jun 4, 2024
@Kojec1 Kojec1 closed this Jun 4, 2024
@Kojec1 Kojec1 reopened this Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (75f5924) to head (dd7fe1e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          30       30           
  Lines        1468     1468           
=======================================
  Hits         1351     1351           
  Misses        117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo slayoo force-pushed the example/advection_diffusion_2d branch from f9a1489 to 5de1594 Compare June 4, 2024 16:06
@slayoo
Copy link
Member

slayoo commented Jun 4, 2024

@Kojec1 @pawelmagnu the matplotlib version issue is now fixed in the main branch, so I've just rebased this PR's branch accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants