-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic when passing context AND nil in a table Entry #1415
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On
DescribeTable
when adding a context parameter, and a pointer parameter, if the parameter is nil, the test exit with panic.This example reproduces the issue (note: this is the simplest reproduction I found. This is why the context is not in use; but this is happening also if the context is in use).
When running the test, it fails for building the tree:
Notes:
Additional info:
The cause is the
nil
parameter in the firstEntry
.The panic is from here:
ginkgo/table_dsl.go
Line 275 in fcf1fd7
entry.parameters[0]
isnil
, soreflect.TypeOf(entry.parameters[0])
is alsonil
, and thenreflect.TypeOf(entry.parameters[0]).Implements(contextType))
panics.The text was updated successfully, but these errors were encountered: