Use ginkgo's context in e2e #2952

nunnatsa · 2024-05-08T09:21:11Z

What this PR does / why we need it

Use ginkgo contexts instead and let ginkgo handle them, instead of creating our on contexts.

This is prove of concept, so it's done for several tests, but not for all of them.

Release note:

None

coveralls · 2024-05-08T09:26:59Z

Pull Request Test Coverage Report for Build 9504422236

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.792%

Totals
Change from base Build 9483288215:	0.0%
Covered Lines:	5199
Relevant Lines:	6060

💛 - Coveralls

nunnatsa · 2024-05-13T09:52:28Z

/hold

looks like a ginkgo issue: onsi/ginkgo#1415

nunnatsa · 2024-05-28T11:27:17Z

/retest

nunnatsa · 2024-06-02T11:19:56Z

/unhold

tiraboschi · 2024-06-10T12:13:40Z

/approve

kubevirt-bot · 2024-06-10T12:13:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nunnatsa · 2024-06-10T12:30:51Z

/hold

wait for #2988

nunnatsa · 2024-06-13T07:46:07Z

/unhold

@tiraboschi could you PTAL?

nunnatsa · 2024-06-13T10:50:04Z

/retest

tiraboschi · 2024-06-13T12:18:54Z

envs.txt

+[2024-05-19T12:50:42.369Z] INFO:__main__:Received EnvVar: HOSTPATH_PROVISIONER_OPERATOR_RHEL9_CONTAINER_BUILD_BUILD_INFO_JSON={"build_id":3033698,"cg_id":1,"completion_time":"2024-04-30 18:08:42.902921","completion_ts":1.71450048E9,"creation_event_id":57735509,"creation_time":"2024-04-30 18:01:42.618780","creation_ts":1.7145001E9,"draft":false,"epoch":null,"extra":{"image":{"isolated":false,"parent_image_builds":{"registry.redhat.io/rhel9-4-els/rhel:9.4-659":{"id":3019909,"nvr":"rhel-els-container-9.4-659"},"registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9":{"id":3010856,"nvr":"openshift-golang-builder-container-v1.21.9-202404181431.gab74a9a.el9"}},"parent_images":["registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9","registry.redhat.io/rhel9-4-els/rhel:9.4-659"],"parent_build_id":3019909,"odcs":{"compose_ids":[3018863],"signing_intent":"release","signing_intent_overridden":false},"help":null,"remote_sources":[{"name":null,"url":"https://cachito.engineering.redhat.com/api/v1/requests/1363438"}],"index":{"tags":["v4.16.0-145"],"floating_tags":["latest","v4.16.0"],"unique_tags":["cnv-4.16-rhel-9-containers-candidate-70541-20240430175753"],"pull":["registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-provisioner-operator-rhel9@sha256:86c46afec5088164e738fe8b6dfcb5856712bd8cea223ff8ebfd625eff72bb29","registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-provisioner-operator-rhel9:v4.16.0-145"],"digests":{"application/vnd.docker.distribution.manifest.list.v2+json":"sha256:86c46afec5088164e738fe8b6dfcb5856712bd8cea223ff8ebfd625eff72bb29"}},"media_types":["application/vnd.docker.distribution.manifest.list.v2+json","application/vnd.docker.distribution.manifest.v1+json","application/vnd.docker.distribution.manifest.v2+json"]},"osbs_build":{"subtypes":[],"kind":"container_build","engine":"podman"},"submitter":"osbs-brew-access","container_koji_task_id":60894914,"typeinfo":{"remote-sources":[{"name":null,"url":"https://cachito.engineering.redhat.com/api/v1/requests/1363438","archives":["remote-source.json","remote-source.tar.gz"]}],"icm":{"name":"icm","archives":["icm-aarch64.json","icm-x86_64.json"]},"image":{"isolated":false,"parent_image_builds":{"registry.redhat.io/rhel9-4-els/rhel:9.4-659":{"id":3019909,"nvr":"rhel-els-container-9.4-659"},"registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9":{"id":3010856,"nvr":"openshift-golang-builder-container-v1.21.9-202404181431.gab74a9a.el9"}},"parent_images":["registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9","registry.redhat.io/rhel9-4-els/rhel:9.4-659"],"parent_build_id":3019909,"odcs":{"compose_ids":[3018863],"signing_intent":"release","signing_intent_overridden":false},"help":null,"remote_sources":[{"name":null,"url":"https://cachito.engineering.redhat.com/api/v1/requests/1363438"}],"index":{"tags":["v4.16.0-145"],"floating_tags":["latest","v4.16.0"],"unique_tags":["cnv-4.16-rhel-9-containers-candidate-70541-20240430175753"],"pull":["registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-provisioner-operator-rhel9@sha256:86c46afec5088164e738fe8b6dfcb5856712bd8cea223ff8ebfd625eff72bb29","registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-provisioner-operator-rhel9:v4.16.0-145"],"digests":{"application/vnd.docker.distribution.manifest.list.v2+json":"sha256:86c46afec5088164e738fe8b6dfcb5856712bd8cea223ff8ebfd625eff72bb29"}},"media_types":["application/vnd.docker.distribution.manifest.list.v2+json","application/vnd.docker.distribution.manifest.v1+json","application/vnd.docker.distribution.manifest.v2+json"]}},"custom_user_metadata":{"automation_triggered_by":"Dominik Holler","cpaas_pipeline_id":"deb1bad1-c78b-3aa8-8aad-fde125c4120e"}},"id":3033698,"name":"hostpath-provisioner-operator-rhel9-container","nvr":"hostpath-provisioner-operator-rhel9-container-v4.16.0-145","owner_id":6716,"owner_name":"exd-cpaas-bot-prod","package_id":81530,"package_name":"hostpath-provisioner-operator-rhel9-container","promoter_id":null,"promoter_name":null,"promotion_time":null,"promotion_ts":null,"release":"145","source":"https://pkgs.devel.redhat.com/git/containers/hostpath-provisioner-operator#b2915f85e482ef3db17b8abdd1871ff0e22a10de","start_time":"2024-04-30 18:01:42.606282","start_ts":1.7145001E9,"state":1,"task_id":60894914,"version":"v4.16.0","volume_id":0,"volume_name":"DEFAULT","cg_name":"atomic-reactor"}
+[2024-05-19T12:50:42.370Z] INFO:__main__:Received EnvVar: HOSTPATH_PROVISIONER_RHEL9_CONTAINER_BUILD_BUILD_INFO_JSON={"build_id":3038090,"cg_id":1,"completion_time":"2024-05-02 21:54:35.064707","completion_ts":1.71468685E9,"creation_event_id":57778694,"creation_time":"2024-05-02 21:48:25.126350","creation_ts":1.71468646E9,"draft":false,"epoch":null,"extra":{"image":{"isolated":false,"parent_image_builds":{"registry.redhat.io/rhel9-4-els/rhel:9.4-659":{"id":3019909,"nvr":"rhel-els-container-9.4-659"},"registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9":{"id":3010856,"nvr":"openshift-golang-builder-container-v1.21.9-202404181431.gab74a9a.el9"}},"parent_images":["registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9","registry.redhat.io/rhel9-4-els/rhel:9.4-659"],"parent_build_id":3019909,"odcs":{"compose_ids":[3031426],"signing_intent":"unsigned","signing_intent_overridden":false},"help":null,"remote_sources":[{"name":null,"url":"https://cachito.engineering.redhat.com/api/v1/requests/1369698"}],"index":{"tags":["v4.16.0-150"],"floating_tags":["latest","v4.16.0"],"unique_tags":["cnv-4.16-rhel-9-containers-candidate-70765-20240502214629"],"pull":["registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-provisioner-rhel9@sha256:c21f65ff35d256f2d9ab85471a27f4c10b43216924af2b0cfd29c04372e37bc2","registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-provisioner-rhel9:v4.16.0-150"],"digests":{"application/vnd.docker.distribution.manifest.list.v2+json":"sha256:c21f65ff35d256f2d9ab85471a27f4c10b43216924af2b0cfd29c04372e37bc2"}},"media_types":["application/vnd.docker.distribution.manifest.list.v2+json","application/vnd.docker.distribution.manifest.v1+json","application/vnd.docker.distribution.manifest.v2+json"]},"osbs_build":{"subtypes":[],"kind":"container_build","engine":"podman"},"submitter":"osbs-brew-access","container_koji_task_id":60970255,"typeinfo":{"remote-sources":[{"name":null,"url":"https://cachito.engineering.redhat.com/api/v1/requests/1369698","archives":["remote-source.json","remote-source.tar.gz"]}],"icm":{"name":"icm","archives":["icm-aarch64.json","icm-x86_64.json"]},"image":{"isolated":false,"parent_image_builds":{"registry.redhat.io/rhel9-4-els/rhel:9.4-659":{"id":3019909,"nvr":"rhel-els-container-9.4-659"},"registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9":{"id":3010856,"nvr":"openshift-golang-builder-container-v1.21.9-202404181431.gab74a9a.el9"}},"parent_images":["registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9","registry.redhat.io/rhel9-4-els/rhel:9.4-659"],"parent_build_id":3019909,"odcs":{"compose_ids":[3031426],"signing_intent":"unsigned","signing_intent_overridden":false},"help":null,"remote_sources":[{"name":null,"url":"https://cachito.engineering.redhat.com/api/v1/requests/1369698"}],"index":{"tags":["v4.16.0-150"],"floating_tags":["latest","v4.16.0"],"unique_tags":["cnv-4.16-rhel-9-containers-candidate-70765-20240502214629"],"pull":["registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-provisioner-rhel9@sha256:c21f65ff35d256f2d9ab85471a27f4c10b43216924af2b0cfd29c04372e37bc2","registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-provisioner-rhel9:v4.16.0-150"],"digests":{"application/vnd.docker.distribution.manifest.list.v2+json":"sha256:c21f65ff35d256f2d9ab85471a27f4c10b43216924af2b0cfd29c04372e37bc2"}},"media_types":["application/vnd.docker.distribution.manifest.list.v2+json","application/vnd.docker.distribution.manifest.v1+json","application/vnd.docker.distribution.manifest.v2+json"]}},"custom_user_metadata":{"cpaas_pipeline_id":"184cb8ce-67e3-3de0-b594-40bb70ff93f7"}},"id":3038090,"name":"hostpath-provisioner-rhel9-container","nvr":"hostpath-provisioner-rhel9-container-v4.16.0-150","owner_id":6716,"owner_name":"exd-cpaas-bot-prod","package_id":81529,"package_name":"hostpath-provisioner-rhel9-container","promoter_id":null,"promoter_name":null,"promotion_time":null,"promotion_ts":null,"release":"150","source":"https://pkgs.devel.redhat.com/git/containers/hostpath-provisioner#a586be55fdea052dc40142bf0154e1d04eb37f72","start_time":"2024-05-02 21:48:25.122304","start_ts":1.71468646E9,"state":1,"task_id":60970255,"version":"v4.16.0","volume_id":0,"volume_name":"DEFAULT","cg_name":"atomic-reactor"}
+[2024-05-19T12:50:42.371Z] INFO:__main__:Received EnvVar: HOSTPATH_CSI_DRIVER_RHEL9_CONTAINER_BUILD_BUILD_INFO_JSON={"build_id":3038089,"cg_id":1,"completion_time":"2024-05-02 21:53:09.994762","completion_ts":1.71468685E9,"creation_event_id":57778692,"creation_time":"2024-05-02 21:48:21.485304","creation_ts":1.71468646E9,"draft":false,"epoch":null,"extra":{"image":{"isolated":false,"parent_image_builds":{"registry.redhat.io/rhel9-4-els/rhel:9.4-659":{"id":3019909,"nvr":"rhel-els-container-9.4-659"},"registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9":{"id":3010856,"nvr":"openshift-golang-builder-container-v1.21.9-202404181431.gab74a9a.el9"}},"parent_images":["registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9","registry.redhat.io/rhel9-4-els/rhel:9.4-659"],"parent_build_id":3019909,"odcs":{"compose_ids":[3031425],"signing_intent":"unsigned","signing_intent_overridden":false},"help":null,"remote_sources":[{"name":null,"url":"https://cachito.engineering.redhat.com/api/v1/requests/1369697"}],"index":{"tags":["v4.16.0-149"],"floating_tags":["latest","v4.16.0"],"unique_tags":["cnv-4.16-rhel-9-containers-candidate-70336-20240502214541"],"pull":["registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-csi-driver-rhel9@sha256:a58b29a4f47eb27e24d8226bf1593862feae77eb2cb9c412c3fe7a2eb466a761","registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-csi-driver-rhel9:v4.16.0-149"],"digests":{"application/vnd.docker.distribution.manifest.list.v2+json":"sha256:a58b29a4f47eb27e24d8226bf1593862feae77eb2cb9c412c3fe7a2eb466a761"}},"media_types":["application/vnd.docker.distribution.manifest.list.v2+json","application/vnd.docker.distribution.manifest.v1+json","application/vnd.docker.distribution.manifest.v2+json"]},"osbs_build":{"subtypes":[],"kind":"container_build","engine":"podman"},"submitter":"osbs-brew-access","container_koji_task_id":60970254,"typeinfo":{"remote-sources":[{"name":null,"url":"https://cachito.engineering.redhat.com/api/v1/requests/1369697","archives":["remote-source.json","remote-source.tar.gz"]}],"icm":{"name":"icm","archives":["icm-aarch64.json","icm-x86_64.json"]},"image":{"isolated":false,"parent_image_builds":{"registry.redhat.io/rhel9-4-els/rhel:9.4-659":{"id":3019909,"nvr":"rhel-els-container-9.4-659"},"registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9":{"id":3010856,"nvr":"openshift-golang-builder-container-v1.21.9-202404181431.gab74a9a.el9"}},"parent_images":["registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9","registry.redhat.io/rhel9-4-els/rhel:9.4-659"],"parent_build_id":3019909,"odcs":{"compose_ids":[3031425],"signing_intent":"unsigned","signing_intent_overridden":false},"help":null,"remote_sources":[{"name":null,"url":"https://cachito.engineering.redhat.com/api/v1/requests/1369697"}],"index":{"tags":["v4.16.0-149"],"floating_tags":["latest","v4.16.0"],"unique_tags":["cnv-4.16-rhel-9-containers-candidate-70336-20240502214541"],"pull":["registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-csi-driver-rhel9@sha256:a58b29a4f47eb27e24d8226bf1593862feae77eb2cb9c412c3fe7a2eb466a761","registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-csi-driver-rhel9:v4.16.0-149"],"digests":{"application/vnd.docker.distribution.manifest.list.v2+json":"sha256:a58b29a4f47eb27e24d8226bf1593862feae77eb2cb9c412c3fe7a2eb466a761"}},"media_types":["application/vnd.docker.distribution.manifest.list.v2+json","application/vnd.docker.distribution.manifest.v1+json","application/vnd.docker.distribution.manifest.v2+json"]}},"custom_user_metadata":{"cpaas_pipeline_id":"184cb8ce-67e3-3de0-b594-40bb70ff93f7"}},"id":3038089,"name":"hostpath-csi-driver-rhel9-container","nvr":"hostpath-csi-driver-rhel9-container-v4.16.0-149","owner_id":6716,"owner_name":"exd-cpaas-bot-prod","package_id":81531,"package_name":"hostpath-csi-driver-rhel9-container","promoter_id":null,"promoter_name":null,"promotion_time":null,"promotion_ts":null,"release":"149","source":"https://pkgs.devel.redhat.com/git/containers/hostpath-csi-driver#e0ee175e55be234c3accf1a068f024ddef60b931","start_time":"2024-05-02 21:48:21.481335","start_ts":1.71468646E9,"state":1,"task_id":60970254,"version":"v4.16.0","volume_id":0,"volume_name":"DEFAULT","cg_name":"atomic-reactor"}
+[2024-05-19T12:50:42.373Z] INFO:__main__:Received EnvVar: HOSTPATH_PROVISIONER_RHEL9_CONTAINER_BUILD_BUILD_INFO_JSON={"build_id":3038090,"cg_id":1,"completion_time":"2024-05-02 21:54:35.064707","completion_ts":1.71468685E9,"creation_event_id":57778694,"creation_time":"2024-05-02 21:48:25.126350","creation_ts":1.71468646E9,"draft":false,"epoch":null,"extra":{"image":{"isolated":false,"parent_image_builds":{"registry.redhat.io/rhel9-4-els/rhel:9.4-659":{"id":3019909,"nvr":"rhel-els-container-9.4-659"},"registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9":{"id":3010856,"nvr":"openshift-golang-builder-container-v1.21.9-202404181431.gab74a9a.el9"}},"parent_images":["registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9","registry.redhat.io/rhel9-4-els/rhel:9.4-659"],"parent_build_id":3019909,"odcs":{"compose_ids":[3031426],"signing_intent":"unsigned","signing_intent_overridden":false},"help":null,"remote_sources":[{"name":null,"url":"https://cachito.engineering.redhat.com/api/v1/requests/1369698"}],"index":{"tags":["v4.16.0-150"],"floating_tags":["latest","v4.16.0"],"unique_tags":["cnv-4.16-rhel-9-containers-candidate-70765-20240502214629"],"pull":["registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-provisioner-rhel9@sha256:c21f65ff35d256f2d9ab85471a27f4c10b43216924af2b0cfd29c04372e37bc2","registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-provisioner-rhel9:v4.16.0-150"],"digests":{"application/vnd.docker.distribution.manifest.list.v2+json":"sha256:c21f65ff35d256f2d9ab85471a27f4c10b43216924af2b0cfd29c04372e37bc2"}},"media_types":["application/vnd.docker.distribution.manifest.list.v2+json","application/vnd.docker.distribution.manifest.v1+json","application/vnd.docker.distribution.manifest.v2+json"]},"osbs_build":{"subtypes":[],"kind":"container_build","engine":"podman"},"submitter":"osbs-brew-access","container_koji_task_id":60970255,"typeinfo":{"remote-sources":[{"name":null,"url":"https://cachito.engineering.redhat.com/api/v1/requests/1369698","archives":["remote-source.json","remote-source.tar.gz"]}],"icm":{"name":"icm","archives":["icm-aarch64.json","icm-x86_64.json"]},"image":{"isolated":false,"parent_image_builds":{"registry.redhat.io/rhel9-4-els/rhel:9.4-659":{"id":3019909,"nvr":"rhel-els-container-9.4-659"},"registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9":{"id":3010856,"nvr":"openshift-golang-builder-container-v1.21.9-202404181431.gab74a9a.el9"}},"parent_images":["registry-proxy.engineering.redhat.com/rh-osbs/openshift-golang-builder:v1.21.9-202404181431.gab74a9a.el9","registry.redhat.io/rhel9-4-els/rhel:9.4-659"],"parent_build_id":3019909,"odcs":{"compose_ids":[3031426],"signing_intent":"unsigned","signing_intent_overridden":false},"help":null,"remote_sources":[{"name":null,"url":"https://cachito.engineering.redhat.com/api/v1/requests/1369698"}],"index":{"tags":["v4.16.0-150"],"floating_tags":["latest","v4.16.0"],"unique_tags":["cnv-4.16-rhel-9-containers-candidate-70765-20240502214629"],"pull":["registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-provisioner-rhel9@sha256:c21f65ff35d256f2d9ab85471a27f4c10b43216924af2b0cfd29c04372e37bc2","registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-hostpath-provisioner-rhel9:v4.16.0-150"],"digests":{"application/vnd.docker.distribution.manifest.list.v2+json":"sha256:c21f65ff35d256f2d9ab85471a27f4c10b43216924af2b0cfd29c04372e37bc2"}},"media_types":["application/vnd.docker.distribution.manifest.list.v2+json","application/vnd.docker.distribution.manifest.v1+json","application/vnd.docker.distribution.manifest.v2+json"]}},"custom_user_metadata":{"cpaas_pipeline_id":"184cb8ce-67e3-3de0-b594-40bb70ff93f7"}},"id":3038090,"name":"hostpath-provisioner-rhel9-container","nvr":"hostpath-provisioner-rhel9-container-v4.16.0-150","owner_id":6716,"owner_name":"exd-cpaas-bot-prod","package_id":81529,"package_name":"hostpath-provisioner-rhel9-container","promoter_id":null,"promoter_name":null,"promotion_time":null,"promotion_ts":null,"release":"150","source":"https://pkgs.devel.redhat.com/git/containers/hostpath-provisioner#a586be55fdea052dc40142bf0154e1d04eb37f72","start_time":"2024-05-02


Do we need this?

tiraboschi · 2024-06-13T12:19:02Z

np.yaml

+ observedGeneration: 1
+ reason: DVNotReady
+ status: "False"
+ type: AllMachinesReady


Use ginkgo contexts instead and let ginkgo handle them, instead of creating our on contexts. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>

sonarcloud · 2024-06-13T17:53:47Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.9% Duplication on New Code

See analysis details on SonarCloud

openshift-ci · 2024-06-13T19:47:28Z

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure	`1880409`	link	false	`/test hco-e2e-upgrade-prev-operator-sdk-sno-azure`
ci/prow/hco-e2e-upgrade-operator-sdk-azure	`1880409`	link	true	`/test hco-e2e-upgrade-operator-sdk-azure`
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure	`1880409`	link	true	`/test hco-e2e-consecutive-operator-sdk-upgrades-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

nunnatsa · 2024-06-13T19:58:53Z

/override-bot

hco-bot · 2024-06-13T19:59:27Z

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure
hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

kubevirt-bot · 2024-06-13T19:59:32Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure, ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to this:

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure
hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 8, 2024

kubevirt-bot requested review from machadovilaca and sradco May 8, 2024 09:21

kubevirt-bot added the size/M label May 8, 2024

nunnatsa force-pushed the poc-ctx-in-tests branch 2 times, most recently from f00c5b3 to 92e573c Compare May 12, 2024 06:30

kubevirt-bot added size/L and removed size/M labels May 12, 2024

nunnatsa force-pushed the poc-ctx-in-tests branch 3 times, most recently from a95bd78 to e366648 Compare May 13, 2024 07:42

kubevirt-bot added size/XL and removed size/L labels May 13, 2024

kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024

nunnatsa force-pushed the poc-ctx-in-tests branch from e366648 to 01202a3 Compare May 28, 2024 07:24

kubevirt-bot added size/XXL and removed size/XL labels May 28, 2024

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2024

nunnatsa force-pushed the poc-ctx-in-tests branch from 85f8d40 to 8ad4e62 Compare June 2, 2024 07:14

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2024

nunnatsa force-pushed the poc-ctx-in-tests branch 4 times, most recently from fca51cf to 2e3a3f4 Compare June 2, 2024 11:18

nunnatsa changed the title ~~POC: use ginkgo's context in e2e~~ Use ginkgo's context in e2e Jun 2, 2024

kubevirt-bot assigned tiraboschi Jun 10, 2024

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024

kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 10, 2024

nunnatsa force-pushed the poc-ctx-in-tests branch from 2e3a3f4 to 7bedd7d Compare June 13, 2024 07:17

kubevirt-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 13, 2024

nunnatsa force-pushed the poc-ctx-in-tests branch 2 times, most recently from fa35628 to 6d6cea1 Compare June 13, 2024 07:24

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2024

tiraboschi reviewed Jun 13, 2024

View reviewed changes

Use ginkgo's context in e2e

1880409

Use ginkgo contexts instead and let ginkgo handle them, instead of creating our on contexts. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>

nunnatsa force-pushed the poc-ctx-in-tests branch from 6d6cea1 to 1880409 Compare June 13, 2024 17:53

kubevirt-bot added size/XL and removed size/XXL labels Jun 13, 2024

tiraboschi approved these changes Jun 14, 2024

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024

kubevirt-bot merged commit 5a542e8 into kubevirt:main Jun 14, 2024
31 checks passed

nunnatsa deleted the poc-ctx-in-tests branch June 14, 2024 07:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ginkgo's context in e2e #2952

Use ginkgo's context in e2e #2952

nunnatsa commented May 8, 2024

coveralls commented May 8, 2024 •

edited

nunnatsa commented May 13, 2024

nunnatsa commented May 28, 2024

nunnatsa commented Jun 2, 2024

tiraboschi commented Jun 10, 2024

kubevirt-bot commented Jun 10, 2024

nunnatsa commented Jun 10, 2024 •

edited

nunnatsa commented Jun 13, 2024

nunnatsa commented Jun 13, 2024

tiraboschi Jun 13, 2024

tiraboschi Jun 13, 2024

sonarcloud bot commented Jun 13, 2024

openshift-ci bot commented Jun 13, 2024

nunnatsa commented Jun 13, 2024

hco-bot commented Jun 13, 2024

kubevirt-bot commented Jun 13, 2024

Use ginkgo's context in e2e #2952

Use ginkgo's context in e2e #2952

Conversation

nunnatsa commented May 8, 2024

What this PR does / why we need it

coveralls commented May 8, 2024 • edited

Pull Request Test Coverage Report for Build 9504422236

Details

💛 - Coveralls

nunnatsa commented May 13, 2024

nunnatsa commented May 28, 2024

nunnatsa commented Jun 2, 2024

tiraboschi commented Jun 10, 2024

kubevirt-bot commented Jun 10, 2024

nunnatsa commented Jun 10, 2024 • edited

nunnatsa commented Jun 13, 2024

nunnatsa commented Jun 13, 2024

tiraboschi Jun 13, 2024

Choose a reason for hiding this comment

tiraboschi Jun 13, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Jun 13, 2024

Quality Gate passed

openshift-ci bot commented Jun 13, 2024

nunnatsa commented Jun 13, 2024

hco-bot commented Jun 13, 2024

kubevirt-bot commented Jun 13, 2024

coveralls commented May 8, 2024 •

edited

nunnatsa commented Jun 10, 2024 •

edited