Advanced Usage documentation fix #1616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comradekingu
commented
Oct 2, 2022
| @@ -25,8 +25,9 @@ Turn Off Private Key | |||
|
|
|||
| By default, all OnionShare services are protected with a private key, which Tor calls "client authentication". | |||
|
|
|||
| The Tor Browser will ask you to enter your private key when you load an OnionShare service. | |||
| If you want allow the public to use your service, it's better to disable the private key altogether. | |||
| The Tor Browser will ask you to enter your private key when you want to offer an OnionShare service. | |||
There was a problem hiding this comment.
Is this done for just authentication, or also encryption.
There was a problem hiding this comment.
Authentication. Tor's onion service protocol itself takes care of encryption.
There was a problem hiding this comment.
I don't think the proposed change is accurate, actually. Private key is prompted by the browser when visiting (not 'offering') an OnionShare service. The original sentence is correct, or perhaps use the verb 'visit' rather than 'load'.
comradekingu
commented
Oct 2, 2022
| The Tor Browser will ask you to enter your private key when you load an OnionShare service. | ||
| If you want allow the public to use your service, it's better to disable the private key altogether. | ||
| The Tor Browser will ask you to enter your private key when you want to offer an OnionShare service. | ||
| If you want to allow the public to use your service, it's better to turn off the private key so that people you don't know |
There was a problem hiding this comment.
This is not good.
There was a problem hiding this comment.
I don't understand the comment.
mig5
reviewed
Oct 18, 2023
| If you want allow the public to use your service, it's better to disable the private key altogether. | ||
| The Tor Browser will ask you to enter your private key when you want to offer an OnionShare service. | ||
| If you want to allow the public to use your service, it's better to turn off the private key so that people you don't know | ||
| wont have to find your public key. |
There was a problem hiding this comment.
Better would be 'so that people won't have to enter it'. Also note wont - ought to be won't.
mig5
requested changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.