Remove unnecessary std::is_partitioned check in dpct::partition_point
#2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Michel <[email protected]>
zhiweij1
approved these changes
Jun 13, 2024
tangjj11
approved these changes
Jun 13, 2024
ziranzha
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With regards to preconditions of the input for
std::partition_point, cppref states, "If the elements elem of [first, last) are not partitioned with respect to the expression bool(p(elem)), the behavior is undefined."We currently check
std::is_partitionedon the input buffer indpct::partition_pointwhich is unnecessary from both the C++ standard and for migration purposes. This check launches an additional kernel that performs a full pass over the buffer and hurts performance.This PR removes this unnecessary check.