[SYCLomatic] Change std numeric to oneapi dpl numeric impl #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this PR needed? These wrappers don't seem to add anything to the oneDPL function they wrap. Can the calling code just call oneDPL directly (or interchangeably, the std API with an execution policy)? |
|
Yes the main intent is to use the dpl invocations directly from numeric than the std:: variants for this numeric file. Also increased the added feature set of reduce ops over the transform_reduce to the code . Doesnt change any functionality of the apis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes numeric.h to support oneapi::dpl:: primitives.
cc @danhoeflinger @mmichel11 @yihanwg @ShengchenJ