Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent an hour trying to figure out why
/auth/developer
wasn't working from the README, and its because the:get
method wasn't allowed forOmniAuth.config.allowed_request_methods
Is there a better way to do this per provider instead of globally for all providers? That would be ideal, but if not, what's the danger of adding
:get
to the default list vs the change I'm proposing?Regardless of the path, this change will prevent future devs from spending lots of time trying to figure out why
/auth/developer
doesn't work.