feat: IMainMenu#getMenuItemForNames API #976
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define menu and menu items "name" - Add new API getMenu with key as a component name - Add new API getMenuItemForNames to help manipulating or retrieving status of menu item. - These API can replace all get*Menu API Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
changed the title
|
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
- avoid unused constant Signed-off-by: Hiroshi Miura <[email protected]>
|
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
miurahr
changed the title
Signed-off-by: Hiroshi Miura <[email protected]>
|
A feature handles a GUI parts. We need a robust GUI test framework to implement unit test for the feature. I've working on Assertj-Swing testing framework to help the proposal tested with it. Now "tokyo.northside:assertj-swing:4.0.0-beta-1" published, so I would like to resume the activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
IMainMenuAPI and use the API inMainWindowMenuHandlerinstead of accessingMainWindowMenuobject methods.Pull request type
refactor
Which ticket is resolved?
dev-ML
https://sourceforge.net/p/omegat/mailman/message/58747200/
What does this PR change?
Other information
TODO: