feat: support GUI test #964
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miurahr
commented
Feb 18, 2024
miurahr
force-pushed
the
topic/miurahr/test/gui/acceptance-test
branch
from
bd6b5d1
to
6fafc3b
Compare
|
❌ Run Gradle test failed: |
1 similar comment
|
❌ Run Gradle test failed: |
miurahr
force-pushed
the
topic/miurahr/test/gui/acceptance-test
branch
from
cf758b8
to
2213112
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
miurahr
force-pushed
the
topic/miurahr/test/gui/acceptance-test
branch
from
45496b4
to
cc164e1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Mar 7, 2024
This comment was marked as outdated.
This comment was marked as outdated.
|
- refacotr main gui classes to allow GUI test
- MainWindowMenuHandler class inherited from BaseMenuHanlder
abstract class
- Tester should implement MenuHandler class for test inherited
from BaseMenuHandler class
- Add testGui configuration on gradle
- Set gui test source under test/gui
- Introduce TestCoreGUI class
- Add BasicMenuItemTest
- test new project creation
- refactor: ProjectPropertiesDialog
- Split looong-method into smaller one
- Give component name
- refactor: extend IMainMenu interface
- refactor: MainWindowUI class
- refactor: MainWindow class
- refactor: MainWindowStatusBar class as 1st citizen class in o.o.gui.main package
- fix: do not assume MainWindow class as JFrame object but always use MainWindow#getApplicationFrame
- refactor: deprecate MainWindowUI class functions
- refactor: add IMainWindow#resetDesktopLayout interface
- chore: add task testAcceptance in gradle
- chore: testAcceptance task on java17
- chore: testAcceptance task with xvfb-run
- refactor: testAcceptance
- Update core can be called from acceptance test class
- Update TestCoreInitializer to call a part of core
- Initialize main window docking style
feat: test with sample project
- refactor: Introduce IProjectFilesList
- Move projWin object in Core
- Initialize projWin in Core#initializeGUI
- MainWindowMenuHandler handle projWin through IProjectFilesList
- feat: test glossary creation operation
- fix: fix modules initialization
- These modules initialize Swing GUI parts in static context. It can be error on non-GUI environment and test environment.
- This fix changes these are initialized in application start event handler.
- feat: load all plugins
- test: check glossary search expectation
- test: explain expected behavior in comment
- refactor: update TestMainWindowMenuHandler
- Add more actions
- Extend IMainWindow#addSearchWindow and IMainWindow#getSearchWindows
- Move internal TestMainWindow class as regular class
- refactor ProjectUICommands.doRecycleTrans and ProjectUICommands.doInsertTrans
- refactor: give ProjectPropertiesDialog UI names
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
force-pushed
the
topic/miurahr/test/gui/acceptance-test
branch
from
fa11d4c
to
f5abb6a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Hiroshi Miura <[email protected]>
|
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Which ticket is resolved?
dev-ML
https://sourceforge.net/p/omegat/mailman/omegat-development/thread/47347769-ccd4-4272-9155-9eaf96c0296c%40northside.tokyo/#msg58743384
What does this PR change?
refacotr main gui classes to allow GUI test - MainWindowMenuHandler class inherited from BaseMenuHanlder abstract class - Tester should implement MenuHandler class for test inherited from BaseMenuHandler class
Add testGui configuration on gradle
Set gui test source under test/gui
Introduce TestCoreGUI class
Add BasicMenuItemTest
Other information