refactor: add IMainWindow#resetDesktopLayout #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend IMainWindow API - Remove dependency to "raw" mainWindow from MainWindowMenuHandler - Update test codes according to API Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
commented
Jun 13, 2024
| /** | ||
| * Restores the main window layout to the default values. | ||
| */ | ||
| default void resetDesktopLayout() {} |
There was a problem hiding this comment.
We add it as default which keeps backward compatibility for plugins compiled with previous versions of OmegaT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend IMainWindow API to add
resetDesktopLayoutto help menu handler to avoid direct dependency for raw MainWindow object to help test code mocking it.Pull request type
refactor
Which ticket is resolved?
What does this PR change?
Other information