Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update tmx writer, escaper, and unit test #1049

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: update tmx writer, escaper, and unit test #1049

wants to merge 7 commits into from

Commits on Jun 2, 2024

  1. fix: update tmx writer test expectation 

    - use double quote for attribute
- format indentation and empty line

Signed-off-by: Hiroshi Miura <[email protected]>
    @miurahr
    miurahr committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    78e7fe7 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. feat: use custom escape writer for tmx write 

    - Add TmxEscapingWriterFactory and inner EscapeWriter class
- Set custom factory with P_TEXT_ESCAPER property

Signed-off-by: Hiroshi Miura <[email protected]>
    @miurahr
    miurahr committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    3592dc3 View commit details
    Browse the repository at this point in the history

  2. refactor: optimize loop 

    Signed-off-by: Hiroshi Miura <[email protected]>
    @miurahr
    miurahr committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    aa3983d View commit details
    Browse the repository at this point in the history

  3. style: update copyright header 

    Signed-off-by: Hiroshi Miura <[email protected]>
    @miurahr
    miurahr committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0363a9e View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. fix: handle \r in windows 

    Signed-off-by: Hiroshi Miura <[email protected]>
    @miurahr
    miurahr committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    a5ea8d4 View commit details
    Browse the repository at this point in the history

  2. style: update unit test 

    Signed-off-by: Hiroshi Miura <[email protected]>
    @miurahr
    miurahr committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e8a4dac View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. fix: test to get result explicit with UTF-8 charset 

    Signed-off-by: Hiroshi Miura <[email protected]>
    @miurahr
    miurahr committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    0523407 View commit details
    Browse the repository at this point in the history