feat: Improve spell checker: use dict bundled in LT, drop jmyspell, and add morfologik #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
miurahr
force-pushed
the
topic/miurahr/spell-checker/morfologik-module
branch
from
13f031d
to
e46cc45
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
miurahr
requested review from
Kazephil,
brandelune and
kosivantsov
as code owners
miurahr
changed the title
brandelune
approved these changes
May 24, 2024
|
There is unrelated coding style fixes in |
Signed-off-by: Hiroshi Miura <[email protected]>
- Add morfologik spellcheck module - Rename hunspell-jmyspell to hunspell module - Drop jmyspell fallback - ISpellChecker#initialize return boolean Signed-off-by: Hiroshi Miura <[email protected]>
- Add SpellCheckDictionaryType - OConsts: define morfologik dict file extension Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
force-pushed
the
topic/miurahr/spell-checker/morfologik-module
branch
from
4cf054e
to
2295108
Compare
|
Rebased on master and recreate commits for review. |
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
force-pushed
the
topic/miurahr/spell-checker/morfologik-module
branch
from
6b28a64
to
4e1eb8c
Compare
Signed-off-by: Hiroshi Miura <[email protected]>
LanguageTool bundles Hunspell dictionary in some languages such as de_DE, too. This revert a feature to import LT bundled dictionary when exists. Signed-off-by: Hiroshi Miura <[email protected]>
Morfologik checker use both *.dict and *.info Signed-off-by: Hiroshi Miura <[email protected]>
|
Now unit tests are added, then fix several issues. |
|
Configuration screen is as same as OmegaT 5.8/6.0 but It can handle both Hunspell and Morfologik dictionary; de_DE is Hunspell, en-GB is Morfologik ~/.omegat/spelling$ ls -l
-rw-rw-r-- 1 miurahr miurahr 19214 5月 26 16:23 de_DE.aff
-rw-rw-r-- 1 miurahr miurahr 4868438 5月 26 16:23 de_DE.dic
-rw-rw-r-- 1 miurahr miurahr 718340 5月 26 16:27 en_GB.dict
-rw-rw-r-- 1 miurahr miurahr 506 5月 26 16:27 en_GB.infoand en_GB files are automatically copied from LT. |
|
Unit test cases passed
|
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LanguageTool now uses Morfologik as a spell checker engine, and bundles morfologik dictionary.
This improvement support Morfologik spell checker in OmegaT module.
When you run OmegaT on a project that target language is en_AU then you will find you can check spells
with a LT internal dictionary en_AU.dict that is automatically appears in users spell dictionary dir.
Pull request type
Which ticket is resolved?
What does this PR change?
Other information