make autoFocus optional for SelectRange #4452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Azmi! |
olifolkerd
added
the
PR Awaiting Merge
|
Hey @azmy60 Thanks for this, as it is a new option i will include it in the next feature release. Cheers Oli :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently found a bug related to SelectRange.
beekeeper-studio/beekeeper-studio#2075
Basically, text editor (codemirror) outside tabulator becomes unusable when tabulator tries to gain focus. I think it's related to
document.createRange()in SelectRange and the way that codemirror didn't handle that properly I guess (?).So, I think it would be great to make the
autoFocusoptional.