Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rows on row drag #3594

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Move rows on row drag #3594

wants to merge 3 commits into from

Conversation

adarshk
Copy link

@adarshk adarshk commented Feb 14, 2022

What this PR does:
When a row is dragged, scroll to top or bottom i.e. enables a more interactive drag. This addresses #3249 (comment)

Some issues that remain after applying this PR:

  1. the placeholder element is only available when dragged over certain number of elements beyond which it doesn't move anymore. My guess - is this due to renderVerticalBuffer? I am not sure.
  2. The scroll only happens when when moving the mouse, not when holding it at the bottom position.
  3. Need to test touch events

I need help with the issues mentioned above
I am happy to help further but also would like feedback as I may not have all the context. Currently this is showing the potential changes that are required to enable a more interactive row drag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant