remove stack commands #4352
Merged
remove stack commands #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Lopez <[email protected]>
Signed-off-by: Andrea Falzetti <[email protected]>
* refactor: remove e2e tests code about push Signed-off-by: Javier Lopez <[email protected]> * refactor: remove autodiscovery for push Signed-off-by: Javier Lopez <[email protected]> * refactor: remove code related to okteto push Signed-off-by: Javier Lopez <[email protected]> * integration: remove push from ci Signed-off-by: Javier Lopez <[email protected]> * refactor: remove unused code Signed-off-by: Javier Lopez <[email protected]> --------- Signed-off-by: Javier Lopez <[email protected]>
* remove login cmd Signed-off-by: Andrea Falzetti <[email protected]> * remove gha Signed-off-by: Andrea Falzetti <[email protected]> --------- Signed-off-by: Andrea Falzetti <[email protected]>
Signed-off-by: Javier Lopez <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ultra-mega-release-branch-3.0 #4352 +/- ##
=================================================================
+ Coverage 45.25% 45.76% +0.50%
=================================================================
Files 361 354 -7
Lines 28646 28326 -320
=================================================================
- Hits 12963 12962 -1
+ Misses 14588 14272 -316
+ Partials 1095 1092 -3 |
|
@jLopezbarb I think you selected |
Signed-off-by: Javier Lopez <[email protected]>
Signed-off-by: Javier Lopez <[email protected]>
andreafalzetti
approved these changes
Jun 20, 2024
| @@ -185,8 +184,6 @@ func main() { | |||
| root.AddCommand(remoterun.RemoteRun(ctx, k8sLogger)) | |||
| root.AddCommand(test.Test(ctx, ioController, k8sLogger, at)) | |||
|
|
|||
| // deprecated | |||
| root.AddCommand(stack.Stack(ctx, at, insights, ioController)) | |||
| root.AddCommand(pipeline.Pipeline(ctx)) | |||
There was a problem hiding this comment.
deprecated is still applying for pipeline?
There was a problem hiding this comment.
No, I removed the //deprecated to reflect it. We should probably needed to put it on the side instead of the top of the function.
| @@ -85,8 +85,30 @@ const ( | |||
| maxRestartsToConsiderFailed = 3 | |||
| ) | |||
|
|
|||
| func (sd *Stack) RunDeploy(ctx context.Context, s *model.Stack, options *DeployOptions) error { | |||
There was a problem hiding this comment.
if stack is gone, can we rename this to Compose or similar?
There was a problem hiding this comment.
We removed the command but not the syntax so I think it's ok to leave the name like this
Signed-off-by: Javier Lopez <[email protected]>
Signed-off-by: Javier Lopez <[email protected]>
jLopezbarb
merged commit f7f0f3e
into
ultra-mega-release-branch-3.0
10 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes DEV-427
How to validate
CLI Quality Reminders 馃敡
For both authors and reviewers: