Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove --builder in context use #4349

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

jLopezbarb
Copy link
Contributor

Proposed changes

Fixes DEV-430

Removes the -b or --builder in the okteto context command.

CLI Quality Reminders 馃敡

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

jLopezbarb and others added 4 commits June 14, 2024 17:51
* refactor: remove e2e tests code about push

Signed-off-by: Javier Lopez <[email protected]>

* refactor: remove autodiscovery for push

Signed-off-by: Javier Lopez <[email protected]>

* refactor: remove code related to okteto push

Signed-off-by: Javier Lopez <[email protected]>

* integration: remove push from ci

Signed-off-by: Javier Lopez <[email protected]>

* refactor: remove unused code

Signed-off-by: Javier Lopez <[email protected]>

---------

Signed-off-by: Javier Lopez <[email protected]>
@jLopezbarb jLopezbarb requested a review from a team as a code owner June 18, 2024 09:21
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.88%. Comparing base (85f1f8a) to head (a39ce84).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           ultra-mega-release-branch-3.0    #4349      +/-   ##
=================================================================
- Coverage                          43.90%   43.88%   -0.02%     
=================================================================
  Files                                366      366              
  Lines                              29608    29603       -5     
=================================================================
- Hits                               12999    12991       -8     
- Misses                             15504    15506       +2     
- Partials                            1105     1106       +1     

@jLopezbarb jLopezbarb merged commit 38d752a into ultra-mega-release-branch-3.0 Jun 18, 2024
20 of 22 checks passed
@jLopezbarb jLopezbarb deleted the jlo/dev-430 branch June 18, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants