Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Win e2e tests #4347

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix Win e2e tests #4347

merged 1 commit into from
Jun 17, 2024

Conversation

andreafalzetti
Copy link
Contributor

@andreafalzetti andreafalzetti commented Jun 17, 2024 •
edited
Loading

Proposed changes

Fixes integration tests failure on Win caused by removal of okteto login.

CLI Quality Reminders 馃敡

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

@andreafalzetti
fix: win e2e test
8b55599 
Signed-off-by: Andrea Falzetti <[email protected]>
@andreafalzetti andreafalzetti requested a review from a team as a code owner June 17, 2024 14:38
@andreafalzetti andreafalzetti added the run-e2e When used on a PR run windows & unix e2e label Jun 17, 2024
@andreafalzetti andreafalzetti changed the title feat: configure ci for 3.0 (#4338) Fix Win e2e tests Jun 17, 2024
@andreafalzetti andreafalzetti merged commit b071b6f into ultra-mega-release-branch-3.0 Jun 17, 2024
25 of 27 checks passed
@andreafalzetti andreafalzetti deleted the af/fix-integration-tests-windows branch June 17, 2024 16:22
andreafalzetti added a commit that referenced this pull request Jun 18, 2024
@andreafalzetti
Fix Win e2e tests (#4347)
305a085 
Signed-off-by: Andrea Falzetti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbyol ifbyol ifbyol approved these changes

@jLopezbarb jLopezbarb jLopezbarb approved these changes

Assignees
No one assigned
Labels
3.0 release/internal run-e2e When used on a PR run windows & unix e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreafalzetti @ifbyol @jLopezbarb