remove okteto update
#4346
Merged
remove okteto update
#4346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Falzetti <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ultra-mega-release-branch-3.0 #4346 +/- ##
=================================================================
+ Coverage 43.75% 43.77% +0.02%
=================================================================
Files 369 368 -1
Lines 29818 29803 -15
=================================================================
Hits 13046 13046
+ Misses 15643 15628 -15
Partials 1129 1129 |
andreafalzetti
changed the title
okteto update
jLopezbarb
approved these changes
Jun 17, 2024
cmd/update.go
Outdated
| }, | ||
| } | ||
| } | ||
|
|
||
| // isUpdateAvailable checks if there is a new version available | ||
| func isUpdateAvailable(currentVersion *semver.Version) bool { |
There was a problem hiding this comment.
IMO We should move all these functions into version.go and remove this file. WDYT?
There was a problem hiding this comment.
I meant to do it and then forgot, thanks, done!
ifbyol
approved these changes
Jun 17, 2024
cmd/update.go
Outdated
| }, | ||
| } | ||
| } | ||
|
|
||
| // isUpdateAvailable checks if there is a new version available | ||
| func isUpdateAvailable(currentVersion *semver.Version) bool { |
andreafalzetti
merged commit b4c9d37
into
ultra-mega-release-branch-3.0
11 of 12 checks passed
andreafalzetti
added a commit
that referenced
this pull request
Jun 18, 2024
* remove okteto update Signed-off-by: Andrea Falzetti <[email protected]> * move func * move func * fix: linter --------- Signed-off-by: Andrea Falzetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier Lopez [email protected]# Proposed changes
Fixes: DEV-433
Removing
okteto updateCLI Quality Reminders 馃敡
For both authors and reviewers: